Skip to content

Conversation

maciejmajek
Copy link
Member

Purpose

Nav2 blocking tool for simpler use-cases

Proposed Changes

NavigateToPoseBlockingTool

Issues

  • Links to relevant issues

Testing

  • How was it tested, what were the results?

Copy link
Collaborator

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me.
Nit, the term "blocking" might suggest the pose is blocked/obstructed, rather than the execution being synchronous. An alternative would be NavigateToPoseSyncTool.

@maciejmajek
Copy link
Member Author

maciejmajek commented Sep 2, 2025

Thank you, @Juliaj. I agree that the naming may be confusing.
LangChain tools support both cases: the _run (sync) and _arun (async) methods.
I wanted to reduce the naming similarity, but I’ll definitely think about it a bit more.
image

@maciejmajek maciejmajek merged commit cefdffd into main Sep 12, 2025
6 checks passed
@maciejmajek maciejmajek deleted the feat/new-tools branch September 12, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants